[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clea
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v3] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clear' register |
|
Date: |
Tue, 18 Feb 2020 16:09:59 +0000 |
On Mon, 17 Feb 2020 at 13:29, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Fix warning reported by Clang static code analyzer:
>
> CC hw/misc/iotkit-secctl.o
> hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is never
> read
> value &= 0x00f000f3;
> ^ ~~~~~~~~~~
>
> Fixes: b3717c23e1c
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v3: AND the register... (pm215)
> v2: Corrected bitwise-not precedence (pm215)
> ---
> hw/misc/iotkit-secctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to target-arm.next, thanks.
-- PMM