[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [kvm-unit-tests PATCH v2 6/9] arm: pmu: Test chained counter
From: |
Auger Eric |
Subject: |
Re: [kvm-unit-tests PATCH v2 6/9] arm: pmu: Test chained counter |
Date: |
Tue, 11 Feb 2020 19:30:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Peter,
On 2/11/20 5:24 PM, Peter Maydell wrote:
> On Thu, 30 Jan 2020 at 11:26, Eric Auger <address@hidden> wrote:
>>
>> Add 2 tests exercising chained counters. The first one uses
>> CPU_CYCLES and the second one uses SW_INCR.
>>
>> Signed-off-by: Eric Auger <address@hidden>
>> +static void test_chained_sw_incr(void)
>> +{
>> + uint32_t events[] = { 0x0 /* SW_INCR */, 0x0 /* SW_INCR */};
>
> Cut-n-paste error? This test relies on the CHAIN event but it
> isn't present in this list of events to pass to satisfy_prerequisites(),
> so I suspect the second element should be "0x1e /* CHAIN */" ?
No that's not a cut-n-paste error. I may rename the test into test_sw_incr.
It starts by testing unchained SW_INCR.
chained SW_INCR testing start with
/* 64b SW_INCR */
>
> (This makes the test fail on QEMU TCG, because we don't implement
> CHAIN.)
OK
Thanks
Eric
>
> thanks
> -- PMM
>