[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU prope
From: |
Andrew Jones |
Subject: |
Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property |
Date: |
Thu, 6 Feb 2020 13:40:47 +0100 |
On Thu, Feb 06, 2020 at 01:08:53PM +0100, Philippe Mathieu-Daudé wrote:
...
> > +/* KVM VCPU properties should be prefixed with "kvm-". */
> > +void kvm_arm_add_vcpu_properties(Object *obj)
> > +{
> > + if (!kvm_enabled()) {
>
> This can't happen, right? Can we turn that into an assertion, or
> remove the check?
You're right. An assert would be more appropriate. Will you send a patch?
Thanks,
drew