[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RESEND PATCH v21 2/6] docs: APEI GHES generation and CPER record de
|
From: |
Igor Mammedov |
|
Subject: |
Re: [RESEND PATCH v21 2/6] docs: APEI GHES generation and CPER record description |
|
Date: |
Wed, 27 Nov 2019 09:12:37 +0100 |
On Wed, 27 Nov 2019 09:37:57 +0800
Xiang Zheng <address@hidden> wrote:
> Hi Igor,
>
> Thanks for your review!
> Since the series of patches are going to be merged, we will address your
> comments by follow up patches.
Yes, I know it's quite frustrating to respin series multiple times,
but on the other hand it's more frustrating later on when reader
tries to figure out mess caused by a bunch of fixups in commit
history.
With amount of issues spotted during review, which also requires
rewriting some patches. I don't see big vXX as a valid reason
to merge without other compelling reason, especially at
the beginning of merge window.
(it might be fine right before soft-freeze if issues are minor
but is not the case here)
If I were you, I'd just respin v22 with comments addressed.
(from my side I can promise to review it shortly after that,
while I still remember how it works)
[...]
Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM, Beata Michalska, 2019/11/22