[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.2 v10 06/15] virtio-iommu: Endpoint and domains structs
|
From: |
Auger Eric |
|
Subject: |
Re: [PATCH for-4.2 v10 06/15] virtio-iommu: Endpoint and domains structs and helpers |
|
Date: |
Mon, 25 Nov 2019 14:14:39 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Jean,
On 11/4/19 7:31 PM, Jean-Philippe Brucker wrote:
> Hi Eric,
>
> On Tue, Jul 30, 2019 at 07:21:28PM +0200, Eric Auger wrote:
>> static void virtio_iommu_device_unrealize(DeviceState *dev, Error **errp)
>> {
>> VirtIODevice *vdev = VIRTIO_DEVICE(dev);
>> + VirtIOIOMMU *s = VIRTIO_IOMMU(dev);
>> +
>> + g_tree_destroy(s->domains);
>> + g_tree_destroy(s->endpoints);
>
> virtio_iommu_device_reset() must completely clear the internal state as
> well (noticed while testing modprobe/rmmod).
I just noticed I forgot to take into account this comment in v11.
I will fix that shortly.
Thanks
Eric
>
> Thanks,
> Jean
>