[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] aspeed/sdmc: Make ast2600 default 1G
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 1/4] aspeed/sdmc: Make ast2600 default 1G |
Date: |
Wed, 13 Nov 2019 12:21:55 +0000 |
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Joel Stanley <address@hidden> writes:
> Most boards have this much.
>
> Reviewed-by: Cédric Le Goater <address@hidden>
> Signed-off-by: Joel Stanley <address@hidden>
> ---
> hw/misc/aspeed_sdmc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
> index f3a63a2e01db..2df3244b53c8 100644
> --- a/hw/misc/aspeed_sdmc.c
> +++ b/hw/misc/aspeed_sdmc.c
> @@ -208,10 +208,10 @@ static int ast2600_rambits(AspeedSDMCState *s)
> }
>
> /* use a common default */
> - warn_report("Invalid RAM size 0x%" PRIx64 ". Using default 512M",
> + warn_report("Invalid RAM size 0x%" PRIx64 ". Using default 1024M",
> s->ram_size);
> - s->ram_size = 512 << 20;
> - return ASPEED_SDMC_AST2600_512MB;
> + s->ram_size = 1024 << 20;
FWIW units.h has some nice #defines to wrap this stuff:
s->ram_size = 1024 * MiB
Not a blocker though:
Reviewed-by: Alex Bennée <address@hidden>
> + return ASPEED_SDMC_AST2600_1024MB;
> }
>
> static void aspeed_sdmc_reset(DeviceState *dev)
--
Alex Bennée