Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

[Peter Maydell]

On Thu, 7 Nov 2019 at 16:57, Alex Bennée <address@hidden> wrote:
>
>
> Beata Michalska <address@hidden> writes:
>
> > On Wed, 6 Nov 2019 at 12:20, Richard Henderson
> > <address@hidden> wrote:
> >> qemu_log_mask w/ GUEST_ERROR?  How do we expect the length to overflow?
> >
> > In theory it shouldn't, at least with current usage.
> > I guess the probe_access will make sure of that.
> > This was more of a precaution to enable catching potential/future misuses
> > aka debugging purpose. I can get rid of that it that's playing too
> > safe.
>
> If the internal code might get it wrong and that would be a bug then the
> g_assert(), if the values are ultimately from the guest then log with
> GUEST_ERROR as Richard suggests.

...or consider asserting at this level and making the target
specific calling code sanitize and do the GUEST_ERROR logging
(it can do a better job of it because it knows what the
target-specific operation that the guest just got wrong was).

thanks
-- PMM