Re: [RFC v2 02/14] standard-headers: import arm_sdei.h

[Michael S. Tsirkin]

On Thu, Nov 07, 2019 at 09:40:49AM +0800, Guoheyi wrote:
> 
> 
> On 2019/11/7 1:52, Cornelia Huck wrote:
> > On Tue, 5 Nov 2019 17:10:44 +0800
> > Heyi Guo <address@hidden> wrote:
> > 
> > > Import Linux header file include/uapi/linux/arm_sdei.h from kernel 
> > > v5.4-rc5.
> > > 
> > > This is to prepare for qemu SDEI emulation.
> > > 
> > > Signed-off-by: Heyi Guo <address@hidden>
> > > Cc: Peter Maydell <address@hidden>
> > > Cc: Dave Martin <address@hidden>
> > > Cc: Marc Zyngier <address@hidden>
> > > Cc: Mark Rutland <address@hidden>
> > > Cc: James Morse <address@hidden>
> > > Cc: "Michael S. Tsirkin" <address@hidden>
> > > Cc: Cornelia Huck <address@hidden>
> > > Cc: Paolo Bonzini <address@hidden>
> > > ---
> > > 
> > > Notes:
> > >      v2:
> > >      - Import arm_sdei.h by running update-linux-headers.sh
> > > 
> > >   include/standard-headers/linux/arm_sdei.h | 73 +++++++++++++++++++++++
> > >   1 file changed, 73 insertions(+)
> > >   create mode 100644 include/standard-headers/linux/arm_sdei.h
> > Just a remark that I find it a bit odd that that a header that looks
> > arm-specific is in the generic linux/ directory (already in the kernel,
> > I know.) Is this for sharing between arm and arm64, maybe?
> I don't think arm platforms will use this header. In section 4.1 of SDEI
> spec, it says " Both the client and dispatcher of SDEI must execute in
> AArch64 state."
> So shall we move it to include/standard-headers/asm-arm64/?
> 
> Thanks,
> HG


Yea, that's because it's used by drivers/firmware/arm_sdei.c, also flat
in the top level hierarchy. It's been like this historically.
If you want to do a small kernel project and reorganize
drivers/firmware/ according to the architecture,
then arm_sdei.h can move too.

Until that happens upstream let's just mirror what kernel does.

> > 
> > 
> > .
> > 
>