[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 19/22] target/arm: Rebuild hflags at Xscale SCTLR writes
From: |
Richard Henderson |
Subject: |
[PATCH v8 19/22] target/arm: Rebuild hflags at Xscale SCTLR writes |
Date: |
Fri, 18 Oct 2019 10:44:28 -0700 |
Continue setting, but not relying upon, env->hflags.
Signed-off-by: Richard Henderson <address@hidden>
---
target/arm/helper.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index aae7b62458..c55783e540 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -4174,6 +4174,16 @@ static void sctlr_write(CPUARMState *env, const
ARMCPRegInfo *ri,
/* ??? Lots of these bits are not implemented. */
/* This may enable/disable the MMU, so do a TLB flush. */
tlb_flush(CPU(cpu));
+
+ if (ri->type & ARM_CP_SUPPRESS_TB_END) {
+ /*
+ * Normally we would always end the TB on an SCTLR write; see the
+ * comment in ARMCPRegInfo sctlr initialization below for why Xscale
+ * is special. Setting ARM_CP_SUPPRESS_TB_END also stops the rebuild
+ * of hflags from the translator, so do it here.
+ */
+ arm_rebuild_hflags(env);
+ }
}
static CPAccessResult fpexc32_access(CPUARMState *env, const ARMCPRegInfo *ri,
--
2.17.1
- [PATCH v8 10/22] target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state, (continued)
- [PATCH v8 10/22] target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/18
- [PATCH v8 09/22] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/18
- [PATCH v8 14/22] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/18
- [PATCH v8 15/22] target/arm: Add HELPER(rebuild_hflags_{a32, a64, m32}), Richard Henderson, 2019/10/18
- [PATCH v8 11/22] target/arm: Hoist computation of TBFLAG_A32.VFPEN, Richard Henderson, 2019/10/18
- [PATCH v8 12/22] target/arm: Add arm_rebuild_hflags, Richard Henderson, 2019/10/18
- [PATCH v8 13/22] target/arm: Split out arm_mmu_idx_el, Richard Henderson, 2019/10/18
- [PATCH v8 17/22] target/arm: Rebuild hflags at MSR writes, Richard Henderson, 2019/10/18
- [PATCH v8 18/22] target/arm: Rebuild hflags at CPSR writes, Richard Henderson, 2019/10/18
- [PATCH v8 16/22] target/arm: Rebuild hflags at EL changes, Richard Henderson, 2019/10/18
- [PATCH v8 19/22] target/arm: Rebuild hflags at Xscale SCTLR writes,
Richard Henderson <=
- [PATCH v8 20/22] target/arm: Rebuild hflags for M-profile, Richard Henderson, 2019/10/18
- [PATCH v8 21/22] target/arm: Rebuild hflags for M-profile NVIC, Richard Henderson, 2019/10/18
- [PATCH v8 22/22] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/18
- Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state, Peter Maydell, 2019/10/22