[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime
From: |
Andrew Jones |
Subject: |
Re: [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime |
Date: |
Thu, 10 Oct 2019 08:29:29 +0200 |
User-agent: |
NeoMutt/20180716 |
On Wed, Oct 09, 2019 at 08:50:02PM -0400, Richard Henderson wrote:
> On 10/7/19 1:06 PM, Andrew Jones wrote:
> > +static void kvm_arm_vm_state_change(void *opaque, int running, RunState
> > state)
> > +{
> > + CPUState *cs = opaque;
> > + ARMCPU *cpu = ARM_CPU(cs);
> > +
> > + if (running) {
> > + if (cpu->kvm_adjvtime) {
> > + kvm_arm_set_virtual_time(cs);
> > + }
> > + }
> > +}
>
> Worth putting this in kvm.c too, so you don't have to duplicate it? You can
> always split it apart later if you ever do need a different hook for 32 vs 64.
True. I'll send a v1 without the premature duplication of this function
and your r-b's
Thanks,
drew
- [RFC PATCH 0/5] target/arm/kvm: Provide an option to adjust virtual time, Andrew Jones, 2019/10/07
- [RFC PATCH 1/5] target/arm/kvm64: kvm64 cpus have timer registers, Andrew Jones, 2019/10/07
- [RFC PATCH 2/5] timer: arm: Introduce functions to get the host cntfrq, Andrew Jones, 2019/10/07
- [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime, Andrew Jones, 2019/10/07
- [RFC PATCH 4/5] tests/arm-cpu-features: Check feature default values, Andrew Jones, 2019/10/07
- [RFC PATCH 5/5] target/arm/cpu: Add the kvm-adjvtime CPU property, Andrew Jones, 2019/10/07