[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file
From: |
Peter Maydell |
Subject: |
Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c |
Date: |
Mon, 23 Sep 2019 15:34:42 +0100 |
On Sat, 21 Sep 2019 at 16:04, Thomas Huth <address@hidden> wrote:
>
> We are going to make CONFIG_ARM_V7M optional, so the related cortex-m
> CPUs should only be created if the switch is enabled. This can best
> be done if the code resides in a separate file, thus move the related
> functions to a new file v7m.c which only gets compiled if CONFIG_ARM_V7M
> is enabled.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> target/arm/Makefile.objs | 1 +
> target/arm/cpu.c | 146 -----------------------------
> target/arm/v7m.c | 193 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 194 insertions(+), 146 deletions(-)
> create mode 100644 target/arm/v7m.c
Calling the new file something with 'cpu' in it would help
to convey that it does the same kinds of things as
cpu.c and cpu64.c. Maybe cpu-m.c or cpu-v7m.c ?
thanks
-- PMM
- Re: [PATCH 1/4] target/arm: Make cpu_register() and set_feature() available for other files, (continued)
Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c,
Peter Maydell <=
[PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds, Thomas Huth, 2019/09/21
- Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds, Peter Maydell, 2019/09/23
- Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds, Thomas Huth, 2019/09/23
- Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds, Peter Maydell, 2019/09/23
- Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds, Thomas Huth, 2019/09/23
- Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds, Peter Maydell, 2019/09/23
- Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds, Thomas Huth, 2019/09/24
- Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds, Peter Maydell, 2019/09/24
- Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds, Thomas Huth, 2019/09/24