[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [RFC 3/3] virt: Check KVM_CAP_ARM_IRQ_LINE_L
From: |
Auger Eric |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [RFC 3/3] virt: Check KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 for smp_cpus > 256 |
Date: |
Wed, 28 Aug 2019 08:19:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Richard,
On 8/28/19 5:28 AM, Richard Henderson wrote:
> On 8/27/19 9:05 AM, Eric Auger wrote:
>> +++ b/target/arm/kvm_arm.h
>> @@ -233,6 +233,14 @@ bool kvm_arm_pmu_supported(CPUState *cs);
>> */
>> int kvm_arm_get_max_vm_ipa_size(MachineState *ms);
>>
>> +/**
>> + * kvm_arm_irq_line_layout_2 - Returns whether more than 256
>> + * vcpus are supported by KVM_IRQ_LINE
>> + *
>> + * @ms: Machine state handle
>> + */
>> +bool kvm_arm_irq_line_layout_2(MachineState *ms);
>> +
>> /**
>> * kvm_arm_sync_mpstate_to_kvm
>> * @cpu: ARMCPU
>> @@ -280,6 +288,11 @@ static inline int
>> kvm_arm_get_max_vm_ipa_size(MachineState *ms)
>> return -ENOENT;
>> }
>>
>> +static inline int kvm_arm_irq_line_layout_2(MachineState *ms)
>> +{
>> + return -ENOENT;
>> +}
>> +
>
> These signatures don't match.
thanks for spotting this. I will fix it.
Best Regards
Eric
>
>
> r~
>