qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [EXTERNAL]Re: [Qemu-devel] [PATCH v5 09/15] cputlb: Acces


From: Aleksandar Markovic
Subject: Re: [Qemu-arm] [EXTERNAL]Re: [Qemu-devel] [PATCH v5 09/15] cputlb: Access MemoryRegion with MemOp
Date: Fri, 26 Jul 2019 11:23:41 +0000


________________________________________
From: Philippe Mathieu-Daudé <address@hidden>
Sent: Friday, July 26, 2019 1:03 PM
To: address@hidden; address@hidden
Cc: address@hidden; address@hidden; address@hidden; address@hidden; 
address@hidden; address@hidden; address@hidden; address@hidden; address@hidden; 
Aleksandar Rikalo; address@hidden; address@hidden; address@hidden; 
address@hidden; address@hidden; address@hidden; address@hidden; address@hidden; 
address@hidden; address@hidden; address@hidden; address@hidden; address@hidden; 
address@hidden; address@hidden; address@hidden; Aleksandar Markovic; 
address@hidden; address@hidden
Subject: [EXTERNAL]Re: [Qemu-devel] [PATCH v5 09/15] cputlb: Access 
MemoryRegion with MemOp

On 7/26/19 8:46 AM, address@hidden wrote:
> No-op MEMOP_SIZE and SIZE_MEMOP macros allows us to later easily
> convert memory_region_dispatch_{read|write} paramter "unsigned size"
> into a size+sign+endianness encoded "MemOp op".
>
> Being a no-op macro, this patch does not introduce any logical change.
>

The last sentence has a bad structure. Possible remedy:

"Being a no-op macro," -> "Relying no-op macros,"

I think this patch should be reogranized (possibly by splitting) so that
the hunks that introduce usage of macros are in a separate patch, which
would leave only changes that directly involve using "MemOp" in this
patch.

Thanks,
Aleksandar



reply via email to

[Prev in Thread] Current Thread [Next in Thread]