[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends on
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-arm] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends on USB & BLUETOOTH |
|
Date: |
Fri, 12 Jul 2019 16:58:08 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 12/07/19 16:16, Philippe Mathieu-Daudé wrote:
> I wondered but am not sure, it is default to Yes, but Bluetooth code is
> deprecated and print a big warning when you use it, so I think this
> device should not be selected as default, neither pull in the deprecated
> bluetooth code.
>
> So personally I'd respin without 'default y'. If you have a good reason
> to use it, I can use 'select' instead.
There are two separate questions. One is whether USB_BLUETOOTH should
select BLUETOOTH and the answer there is almost certainly yes (in the
words of kconfig.rst, BLUETOOTH is a "subsystem" while USB_BLUETOOTH is
a "device"; devices select the bus that the device provides).
The other is whether we want to enable USB_BLUETOOTH by default. I
wouldn't have any problem there, but if we disable it basically no one
would ship/use it and we might as well delete the whole thing.
Paolo
[Qemu-arm] [PATCH-for-4.1? 3/7] MAINTAINERS: Add an entry for the Bluetooth devices, Philippe Mathieu-Daudé, 2019/07/12
[Qemu-arm] [PATCH-for-4.1? 4/7] vl: Fix 'braces' coding style issues, Philippe Mathieu-Daudé, 2019/07/12
[Qemu-arm] [PATCH-for-4.1? 5/7] vl: Use qemu_strtoi() instead of strtol(), Philippe Mathieu-Daudé, 2019/07/12
[Qemu-arm] [PATCH-for-4.1? 6/7] vl: Extract bt_parse() into its own file, Philippe Mathieu-Daudé, 2019/07/12
[Qemu-arm] [PATCH-for-4.1? 7/7] hw/bt: Allow building with CONFIG_BLUETOOTH disabled, Philippe Mathieu-Daudé, 2019/07/12
Re: [Qemu-arm] [Qemu-devel] [PATCH-for-4.1? 0/7] vl: Allow building with CONFIG_BLUETOOTH disabled, Richard Henderson, 2019/07/14