Re: [Qemu-arm] [PATCH for semihosting-tests 2/2] semihosting tests: add v7m tests

[Peter Maydell]

On Wed, 10 Jul 2019 at 14:13, Alex Bennée <address@hidden> wrote:
>
> M-profile has yet another way of triggering semihosting calls using
> the BKPT instruction. To support this we need to add a M-profile setup
> so we use the nice and simple microbit model which has a Cortex-M0 in
> it.
>
> Signed-off-by: Alex Bennée <address@hidden>

This generally looks good. One issue: when linking the
compiler prints this warning:

arm-none-eabi-gcc -mcpu=cortex-m0 -mfloat-abi=soft -DUSE_BKPT -o
systest-t32-bkpt.axf microbit.lds start-microbit.S string.c usertest.c
semihosting.c semicall.S printf/printf.c -nostdlib -lgcc -Xlinker
--script=microbit.lds -Xlinker --build-id=none
/usr/lib/gcc/arm-none-eabi/6.3.1/../../../arm-none-eabi/bin/ld:
warning: cannot find entry symbol exc_reset_thumb; defaulting to
0000000000000000

> +ENTRY(exc_reset_thumb)

I guess this should say "reset_thumb" to match the
actual definition:


> +        /* declare as a function so pointers are appropriatley "thumbed" */
> +        .type reset_thumb, function
> +reset_thumb:

?

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

PS: are you deliberately sending these to qemu-arm only
and not qemu-devel ?

thanks
-- PMM