Re: [Qemu-arm] [Qemu-devel] [PATCH v6 0/8] ARM virt: ACPI memory hotplug support

[Peter Maydell]

On Tue, 2 Jul 2019 at 12:07, Igor Mammedov <address@hidden> wrote:
>
> On Tue, 25 Jun 2019 13:14:13 +0100
> Shameer Kolothum <address@hidden> wrote:
>
> > This series is an attempt to provide device memory hotplug support
> > on ARM virt platform. This is based on Eric's recent works here[1]
> > and carries some of the pc-dimm related patches dropped from his
> > series.
> >
> > The kernel support for arm64 memory hot add was added recently by
> > Robin and hence the guest kernel should be => 5.0-rc1.
> >
> > NVDIM support is not included currently as we still have an unresolved
> > issue while hot adding NVDIMM[2]. However NVDIMM cold plug patches
> > can be included, but not done for now, for keeping it simple.
> >
> > This makes use of GED device to sent hotplug ACPI events to the
> > Guest. GED code is based on Nemu. Thanks to the efforts of Samuel and
> > Sebastien to add the hardware-reduced support to Nemu using GED
> > device[3]. (Please shout if I got the author/signed-off wrong for
> > those patches or missed any names).
> >
> > This is sanity tested on a HiSilicon ARM64 platform and appreciate
> > any further testing.
>
> There are several things I'd fix/amend but it's nothing that couldn't
> be done on top as bugfixes (I'll comment later on specific issues).
>
> However as a whole from ACPI and memory hotplug POV series looks more
> or less ready for merging.
>
> I've asked Eric to test migration (I'm quite not sure about that part),
> (CCed David)so on condition it works:
>
>   Reviewed-by: Igor Mammedov <address@hidden>

If we want to get this into 4.1 I'll need somebody to do a respin
with all the relevant fixes pretty soon (ie within a day or two,
and that is pushing it because really it's missed the freeze
deadline already). It might be easier just to let it go into 4.2
instead...

thanks
-- PMM