qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [RFC PATCH] semihosting: split console_out i


From: no-reply
Subject: Re: [Qemu-arm] [Qemu-devel] [RFC PATCH] semihosting: split console_out intro string and char versions
Date: Thu, 30 May 2019 09:12:24 -0700 (PDT)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC PATCH] semihosting: split console_out intro string 
and char versions
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
98c557b357 semihosting: split console_out intro string and char versions

=== OUTPUT BEGIN ===
ERROR: spaces required around that '!=' (ctx:VxV)
#47: FILE: hw/semihosting/console.c:56:
+    } while (c!=0);
               ^

total: 1 errors, 0 warnings, 147 lines checked

Commit 98c557b35708 (semihosting: split console_out intro string and char 
versions) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]