Re: [Qemu-arm] [Qemu-devel] [PATCH v2 04/28] semihosting: enable chardev backed output for console

[Richard Henderson]

On 5/23/19 6:25 AM, Alex Bennée wrote:
>  int qemu_semihosting_log_out(const char *s, int len)
>  {
> -    return write(STDERR_FILENO, s, len);
> +    Chardev *chardev = semihosting_get_chardev();
> +    if (chardev) {
> +        return qemu_chr_write_all(chardev, (uint8_t *) s, len);
> +    } else {
> +        return write(STDERR_FILENO, s, len);
> +    }
>  }

Can we not create a default chardev that outputs to stderr, so that the
conditional is not required?  Or does that somehow interfere with how this
connects up for linux-user/?


r~