Re: [Qemu-arm] [PATCH 2/2] target/arm: Use tcg_gen_gvec_bitsel

[Peter Maydell]

On Thu, 23 May 2019 at 14:16, Richard Henderson
<address@hidden> wrote:
>
> On 5/23/19 9:08 AM, Peter Maydell wrote:
> >> Because the three different instructions perform the same operation with
> >> reshuffled register arguments.
> >
> > Ah, so they do. Next question, how do I find out what the
> > order of arguments in the above code means so I can compare
> > it against the pseudocode expression we're implementing?
>
> >From tcg/README:
>
> * bitsel_vec v0, v1, v2, v3
>
>   Bitwise select, v0 = (v2 & v1) | (v3 & ~v1), across the entire vector.
>
> The "selector" is second, the first input operand.

Oh, this series is based on another patchset.

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM