[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 1/1] target/arm: Fix vector operation segfault
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [PATCH v2 1/1] target/arm: Fix vector operation segfault |
|
Date: |
Tue, 14 May 2019 17:28:36 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/14/19 5:21 PM, Alistair Francis wrote:
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index dd053c80d6..298c262825 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -6598,13 +6598,13 @@ static int disas_neon_data_insn(DisasContext *s,
> uint32_t insn)
> tcg_gen_gvec_4(rd_ofs, offsetof(CPUARMState, vfp.qc),
> rn_ofs, rm_ofs, vec_size, vec_size,
> (u ? uqadd_op : sqadd_op) + size);
> - break;
> + return 0;
>
> case NEON_3R_VQSUB:
> tcg_gen_gvec_4(rd_ofs, offsetof(CPUARMState, vfp.qc),
> rn_ofs, rm_ofs, vec_size, vec_size,
> (u ? uqsub_op : sqsub_op) + size);
> - break;
> + return 0;
>
> case NEON_3R_VMUL: /* VMUL */
> if (u) {
Reviewed-by: Richard Henderson <address@hidden>
r~