Re: [Qemu-arm] [Qemu-devel] [PATCH v5 06/15] tests/tcg/multiarch: expand system memory test to cover more

[Richard Henderson]

On 4/30/19 9:52 AM, Alex Bennée wrote:
> +int do_signed_reads(bool neg_first)
> +{
> +    int r = 0;
> +    int off = 0;
> +
> +    while (r == 0 && off < 8) {
> +        r = read_test_data_s8(off, neg_first ^ (off & 1));
> +        r |= read_test_data_s16(off, !(neg_first ^ (off & 1)));
> +        r |= read_test_data_s32(off, !(neg_first ^ (off & 1)));

You're testing unaligned reads here.

While admirable, and necessary, that's going to limit the number of guests on
which you can run this test.

Do you perhaps want a compiler command-line -DALIGNED_ONLY to control this?

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~