[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v3 2/6] hw/arm/virt-acpi-build: remove unnecessary var
From: |
Wei Yang |
Subject: |
[Qemu-arm] [PATCH v3 2/6] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start |
Date: |
Wed, 17 Apr 2019 09:40:34 +0800 |
mcfg_start points to the start of MCFG table and is used in
build_header. While this information could be derived from mcfg.
This patch removes the unnecessary variable mcfg_start.
Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/arm/virt-acpi-build.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 857989362a..e09e7eff8d 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -552,7 +552,6 @@ build_mcfg(GArray *table_data, BIOSLinker *linker,
VirtMachineState *vms)
const MemMapEntry *memmap = vms->memmap;
int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam);
int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]);
- int mcfg_start = table_data->len;
mcfg = acpi_data_push(table_data, len);
mcfg->allocation[0].address = cpu_to_le64(memmap[ecam_id].base);
@@ -563,8 +562,7 @@ build_mcfg(GArray *table_data, BIOSLinker *linker,
VirtMachineState *vms)
mcfg->allocation[0].end_bus_number =
PCIE_MMCFG_BUS(memmap[ecam_id].size - 1);
- build_header(linker, table_data, (void *)(table_data->data + mcfg_start),
- "MCFG", table_data->len - mcfg_start, 1, NULL, NULL);
+ build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL, NULL);
}
/* GTDT */
--
2.19.1
- [Qemu-arm] [PATCH v3 0/6] Extract build_mcfg, Wei Yang, 2019/04/16
- [Qemu-arm] [PATCH v3 1/6] q35: acpi: do not create dummy MCFG table, Wei Yang, 2019/04/16
- [Qemu-arm] [PATCH v3 3/6] i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members, Wei Yang, 2019/04/16
- [Qemu-arm] [PATCH v3 4/6] hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg(), Wei Yang, 2019/04/16
- [Qemu-arm] [PATCH v3 2/6] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start,
Wei Yang <=
- [Qemu-arm] [PATCH v3 5/6] hw/acpi: Consolidate build_mcfg to pci.c, Wei Yang, 2019/04/16
- [Qemu-arm] [PATCH v3 6/6] acpi: pci: use build_append_foo() API to construct MCFG, Wei Yang, 2019/04/16