[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 5/5] tests/microbit-test: Add tests for nRF51 N
From: |
Thomas Huth |
Subject: |
Re: [Qemu-arm] [PATCH v2 5/5] tests/microbit-test: Add tests for nRF51 NVMC |
Date: |
Thu, 24 Jan 2019 10:53:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-23 22:22, Stefan Hajnoczi wrote:
> From: Steffen Görtz <address@hidden>
>
> Signed-off-by: Steffen Görtz <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/microbit-test.c | 97 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 97 insertions(+)
>
> diff --git a/tests/microbit-test.c b/tests/microbit-test.c
> index 0c125535f6..d3edd38643 100644
> --- a/tests/microbit-test.c
> +++ b/tests/microbit-test.c
> @@ -20,8 +20,104 @@
>
> #include "hw/arm/nrf51.h"
> #include "hw/gpio/nrf51_gpio.h"
> +#include "hw/nvram/nrf51_nvm.h"
> #include "hw/timer/nrf51_timer.h"
>
> +#define FLASH_SIZE (256 * NRF51_PAGE_SIZE)
> +
> +static void fill_and_erase(hwaddr base, hwaddr size, uint32_t address_reg)
> +{
> + hwaddr i;
> +
> + /* Erase Page */
> + writel(NRF51_NVMC_BASE + NRF51_NVMC_CONFIG, 0x02);
> + writel(NRF51_NVMC_BASE + address_reg, base);
> + writel(NRF51_NVMC_BASE + NRF51_NVMC_CONFIG, 0x00);
I think you might have a conflict here with Julia's patch
"tests/microbit-test: Make test independent of global_qtest". Could you
please have a look (and e.g. include Julia's patches in your series)?
Thanks,
Thomas
[Qemu-arm] [PATCH v2 3/5] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories, Stefan Hajnoczi, 2019/01/23
[Qemu-arm] [PATCH v2 5/5] tests/microbit-test: Add tests for nRF51 NVMC, Stefan Hajnoczi, 2019/01/23
- Re: [Qemu-arm] [PATCH v2 5/5] tests/microbit-test: Add tests for nRF51 NVMC,
Thomas Huth <=
[Qemu-arm] [PATCH v2 4/5] arm: Instantiate NRF51 special NVM's and NVMC, Stefan Hajnoczi, 2019/01/23
Re: [Qemu-arm] [PATCH v2 0/5] arm: microbit Non-Volatile Memory Controller, Peter Maydell, 2019/01/24