qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary c


From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary comment
Date: Fri, 7 Dec 2018 10:46:37 +0000

On Fri, 7 Dec 2018 at 08:19, Peng Hao <address@hidden> wrote:
>
> The registered memory region of i6300esb is not suitable for coalesced
> mmio, because a write for the region may trigger an immediate action
> and can't be delayed.
>
> Signed-off-by: Peng Hao <address@hidden>
> ---
>  hw/watchdog/wdt_i6300esb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
> index 7b59469..1c6eddf 100644
> --- a/hw/watchdog/wdt_i6300esb.c
> +++ b/hw/watchdog/wdt_i6300esb.c
> @@ -449,7 +449,6 @@ static void i6300esb_realize(PCIDevice *dev, Error **errp)
>      memory_region_init_io(&d->io_mem, OBJECT(d), &i6300esb_ops, d,
>                            "i6300esb", 0x10);
>      pci_register_bar(&d->dev, 0, 0, &d->io_mem);
> -    /* qemu_register_coalesced_mmio (addr, 0x10); ? */
>  }
>
>  static void i6300esb_exit(PCIDevice *dev)
> --

Hi -- it looks like you cc'd the wrong mailing list by mistake
here -- this isn't an arm specific device. Patches should all
go to qemu-devel.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]