[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH V10 3/9] hw/misc/pvpanic: Add the MMIO interface
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH V10 3/9] hw/misc/pvpanic: Add the MMIO interface |
Date: |
Fri, 30 Nov 2018 15:41:50 +0000 |
On Wed, 28 Nov 2018 at 03:50, Peng Hao <address@hidden> wrote:
>
> Add pvpanic new type "TYPE_PVPANIC_MMIO"
>
> Signed-off-by: Peng Hao <address@hidden>
> ---
> hw/misc/pvpanic.c | 50
> +++++++++++++++++++++++++++++++++++++++++++----
> include/hw/misc/pvpanic.h | 1 +
> 2 files changed, 47 insertions(+), 4 deletions(-)
>
> +static void pvpanic_mmio_initfn(Object *obj)
> +{
> + PVPanicMMIOState *s = PVPANIC_MMIO_DEVICE(obj);
> + SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
> +
> + memory_region_init_io(&s->mr, OBJECT(s), &pvpanic_ops, s,
> + TYPE_PVPANIC_MMIO, 2);
Why did you choose to make the memory region 2 bytes wide?
The ISA i/o port interface seems to be a 1 byte wide one.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-arm] [PATCH V10 0/9] add pvpanic mmio support, Peng Hao, 2018/11/27
- [Qemu-arm] [PATCH V10 1/9] hw/misc/pvpanic: Build the pvpanic device in $(common-obj), Peng Hao, 2018/11/27
- [Qemu-arm] [PATCH V10 4/9] hw/arm/virt: Use the pvpanic device, Peng Hao, 2018/11/27
- [Qemu-arm] [PATCH V10 2/9] hw/misc/pvpanic: Cosmetic renaming, Peng Hao, 2018/11/27
- [Qemu-arm] [PATCH V10 3/9] hw/misc/pvpanic: Add the MMIO interface, Peng Hao, 2018/11/27
- Re: [Qemu-arm] [PATCH V10 3/9] hw/misc/pvpanic: Add the MMIO interface,
Peter Maydell <=
- [Qemu-arm] [PATCH V10 5/9] hw/arm/virt: add pvpanic device in virt acpi table, Peng Hao, 2018/11/27
- [Qemu-arm] [PATCH V10 6/9] hw/misc/pvpanic: add configure query interface, Peng Hao, 2018/11/27
- [Qemu-arm] [PATCH V10 9/9] pvpanic : update pvpanic document, Peng Hao, 2018/11/27
- [Qemu-arm] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface, Peng Hao, 2018/11/27