[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] [PATCH] Allow AArch64 processors to
From: |
no-reply |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] [PATCH] Allow AArch64 processors to boot from a kernel placed over 4GB. |
Date: |
Wed, 28 Nov 2018 02:51:45 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] [PATCH] Allow AArch64 processors to boot from a
kernel placed over 4GB.
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
96e23e4 Allow AArch64 processors to boot from a kernel placed over 4GB.
=== OUTPUT BEGIN ===
Checking PATCH 1/1: Allow AArch64 processors to boot from a kernel placed over
4GB....
ERROR: line over 90 characters
#22: FILE: hw/arm/boot.c:67:
+ FIXUP_ARGPTR_HIGHER_32BITS, /* overwrite with pointer to kernel args
(higher 32 bits) */
ERROR: line over 90 characters
#24: FILE: hw/arm/boot.c:69:
+ FIXUP_ENTRYPOINT_HIGHER_32BITS, /* overwrite with kernel entry point
(higher 32 bits) */
WARNING: line over 80 characters
#36: FILE: hw/arm/boot.c:91:
+ { 0, FIXUP_ENTRYPOINT_HIGHER_32BITS }, /* .word @Kernel Entry Higher
32-bits */
ERROR: line over 90 characters
#65: FILE: hw/arm/boot.c:1162:
+ fixupcontext[FIXUP_ARGPTR_HIGHER_32BITS] = (info->loader_start +
KERNEL_ARGS_ADDR) >> 32;
total: 3 errors, 1 warnings, 53 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden