[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v7 12/16] gdbstub: add support for vA
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v7 12/16] gdbstub: add support for vAttach packets |
Date: |
Sun, 25 Nov 2018 22:00:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 23/11/18 10:17, Luc Michel wrote:
> Add support for the vAttach packets. In multiprocess mode, GDB sends
> them to attach to additional processes.
>
> Signed-off-by: Luc Michel <address@hidden>
> Reviewed-by: Edgar E. Iglesias <address@hidden>
> Acked-by: Alistair Francis <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> gdbstub.c | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 5cc643b9e0..69471ea914 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1342,10 +1342,45 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> break;
> }
> goto unknown_command;
> }
> break;
> + } else if (strncmp(p, "Attach;", 7) == 0) {
> + unsigned long pid;
> +
> + p += 7;
> +
> + if (qemu_strtoul(p, &p, 16, &pid)) {
> + put_packet(s, "E22");
> + break;
> + }
> +
> + process = gdb_get_process(s, pid);
> +
> + if (process == NULL) {
> + put_packet(s, "E22");
> + break;
> + }
> +
> + cpu = get_first_cpu_in_process(s, process);
> +
> + if (cpu == NULL) {
> + /* Refuse to attach an empty process */
> + put_packet(s, "E22");
> + break;
> + }
> +
> + process->attached = true;
> +
> + s->g_cpu = cpu;
> + s->c_cpu = cpu;
> +
> + snprintf(buf, sizeof(buf), "T%02xthread:%s;", GDB_SIGNAL_TRAP,
> + gdb_fmt_thread_id(s, cpu, thread_id,
> sizeof(thread_id)));
> +
> + put_packet(s, buf);
> + break;
> } else {
> goto unknown_command;
> }
> case 'k':
> /* Kill the target */
>
[Qemu-arm] [PATCH v7 03/16] gdbstub: add multiprocess support to '?' packets, Luc Michel, 2018/11/23
[Qemu-arm] [PATCH v7 05/16] gdbstub: add multiprocess support to vCont packets, Luc Michel, 2018/11/23
[Qemu-arm] [PATCH v7 12/16] gdbstub: add support for vAttach packets, Luc Michel, 2018/11/23
- Re: [Qemu-arm] [Qemu-devel] [PATCH v7 12/16] gdbstub: add support for vAttach packets,
Philippe Mathieu-Daudé <=
[Qemu-arm] [PATCH v7 06/16] gdbstub: add multiprocess support to 'sC' packets, Luc Michel, 2018/11/23
[Qemu-arm] [PATCH v7 04/16] gdbstub: add multiprocess support to 'H' and 'T' packets, Luc Michel, 2018/11/23
[Qemu-arm] [PATCH v7 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo, Luc Michel, 2018/11/23
[Qemu-arm] [PATCH v7 13/16] gdbstub: processes initialization on new peer connection, Luc Michel, 2018/11/23
[Qemu-arm] [PATCH v7 11/16] gdbstub: add support for extended mode packet, Luc Michel, 2018/11/23
[Qemu-arm] [PATCH v7 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached, Luc Michel, 2018/11/23
[Qemu-arm] [PATCH v7 15/16] gdbstub: add multiprocess extension support, Luc Michel, 2018/11/23
[Qemu-arm] [PATCH v7 16/16] arm/xlnx-zynqmp: put APUs and RPUs in separate CPU clusters, Luc Michel, 2018/11/23