[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for har
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition |
Date: |
Mon, 19 Nov 2018 13:14:36 -0500 |
On Mon, Nov 19, 2018 at 06:14:26PM +0100, Paolo Bonzini wrote:
> On 19/11/18 16:31, Igor Mammedov wrote:
> > I've tried to give suggestions how to restructure series
> > on per patch basis. In my opinion it quite possible to split
> > series in several smaller ones and it should really help with
> > making series cleaner and easier/faster to review/amend/merge
> > vs what we have in v5.
>
> This is true, on the other hand the series makes sense together and,
> even if the patches are more or less independent, they also all follow
> the same "plan". For reviewing v6, are you aware of Patchew's series
> diff functionality? It can tell you which patches had comments in v5,
> reorder patches if applicable, and display deleted and new patches at
> the right point in the series.
>
> v4->v5 is a bit messed up because Samuel probably added a diff order
> setup
> (https://patchew.org/QEMU/address@hidden/diff/address@hidden/)
> but it's very useful in general.
>
> Paolo
Oh I didn't realize difforder breaks patchew. Or is the problem
only if one switches from no order to difforder?
--
MST
- Re: [Qemu-arm] [Qemu-devel] [PATCH v5 20/24] hw: acpi: Define ACPI tables builder interface, (continued)
[Qemu-arm] [PATCH v5 24/24] hw: i386: Refactor PCI host getter, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 23/24] hw: i386: Set ACPI configuration PCI host pointer, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 22/24] hw: pci-host: piix: Return PCI host pointer instead of PCI bus, Samuel Ortiz, 2018/11/04
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Igor Mammedov, 2018/11/16
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Michael S. Tsirkin, 2018/11/21
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Samuel Ortiz, 2018/11/21
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Michael S. Tsirkin, 2018/11/21
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Igor Mammedov, 2018/11/21
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Samuel Ortiz, 2018/11/21
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Igor Mammedov, 2018/11/22
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Samuel Ortiz, 2018/11/21