[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1
From: |
Alex Bennée |
Subject: |
Re: [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write |
Date: |
Mon, 12 Nov 2018 11:13:44 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Richard Henderson <address@hidden> writes:
> This would cause an infinite recursion or loop.
>
> Signed-off-by: Richard Henderson <address@hidden>
I feel the title undersells the importance of the fix ;-)
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 96301930cc..a327988c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env,
> const ARMCPRegInfo *ri,
> CPUState *cs = ENV_GET_CPU(env);
>
> if (tlb_force_broadcast(env)) {
> - tlbi_aa64_vmalle1_write(env, NULL, value);
> + tlbi_aa64_vmalle1is_write(env, NULL, value);
> return;
> }
--
Alex Bennée