[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 12/13] arm: Instantiate NRF51 Timers
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-arm] [PATCH v3 12/13] arm: Instantiate NRF51 Timers |
Date: |
Thu, 1 Nov 2018 13:01:22 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Oct 30, 2018 at 08:25:26PM -0400, Steffen Görtz wrote:
> + /* TIMER */
> + for (i = 0; i < NRF51_NUM_TIMERS; i++) {
> + object_property_set_bool(OBJECT(&s->timer[i]), true, "realized",
> &err);
> + if (err) {
> + error_propagate(errp, err);
> + return;
> + }
> +
> + base_addr = NRF51_TIMER_BASE + i * 0x1000;
s/0x1000/NRF51_TIMER_SIZE/
Aside from that:
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-arm] [PATCH v3 12/13] arm: Instantiate NRF51 Timers,
Stefan Hajnoczi <=