Re: [Qemu-arm] [PATCH v4 3/3] hw/arm/virt: Allow dynamic vfio-platform devices again

[Auger Eric]

Hi Geert,

On 9/13/18 5:44 PM, Geert Uytterhoeven wrote:
> Allow the instantation of generic dynamic vfio-platform devices again,
> without the need to create a new device-specific vfio type.
> 
> This is more or less a partial revert of commit 6f2062b9758ebc64
> ("hw/arm/virt: Allow only supported dynamic sysbus devices").
nit: his last sentence is arguable as before we allowed any sysbus
device dynamic instantiation. I would simply remove it.

Besides
Reviewed-by: Eric Auger <address@hidden>

Thanks

Eric


> 
> Signed-off-by: Geert Uytterhoeven <address@hidden>
> ---
> v4:
>   - s/sysbus/vfio-platform/ in patch description,
> 
> v3:
>   - Drop RFC state,
> 
> v2:
>   - Restrict from TYPE_SYS_BUS_DEVICE to TYPE_VFIO_PLATFORM, as
>     suggested by Eric Auger.
> ---
>  hw/arm/virt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 0b57f87abcbfd54b..e33f7776c72fa9d0 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1758,6 +1758,7 @@ static void virt_machine_class_init(ObjectClass *oc, 
> void *data)
>      machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_CALXEDA_XGMAC);
>      machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_AMD_XGBE);
>      machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE);
> +    machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_PLATFORM);
>      mc->block_default_type = IF_VIRTIO;
>      mc->no_cdrom = 1;
>      mc->pci_allow_0_address = true;
>