Re: [Qemu-arm] [Qemu-devel] [PATCH 2/8] hw/misc/bcm2835_property: Track fb settings using BCM2835FBConfig

[Richard Henderson]

On 08/14/2018 07:44 AM, Peter Maydell wrote:
> Refactor the fb property setting code so that rather than
> using a set of pointers to local variables to track
> whether a config value has been updated in the current
> mbox and if so what its new value is, we just copy
> all the current settings of the fb at the start, and
> then update that copy as we go along, before asking
> the fb to switch to it at the end.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  include/hw/display/bcm2835_fb.h |  4 +-
>  hw/display/bcm2835_fb.c         | 27 ++---------
>  hw/misc/bcm2835_property.c      | 80 ++++++++++++++-------------------
>  3 files changed, 37 insertions(+), 74 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~