[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 22/22] hw/arm/mps2-tz: Fix MPS2 SCC c
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 22/22] hw/arm/mps2-tz: Fix MPS2 SCC config register values |
|
Date: |
Thu, 23 Aug 2018 18:46:59 +0100 |
On 23 August 2018 at 18:45, Peter Maydell <address@hidden> wrote:
> On 23 August 2018 at 18:42, Richard Henderson
> <address@hidden> wrote:
>> On 08/20/2018 07:11 AM, Peter Maydell wrote:
>>> + mmc->scc_id = 0x41040000 | (0x505 << 4);
>>
>> Is it any less clear to say 0x41045050?
>
> It makes it a bit clearer that that field is the number
> from the image name, I think. (Compare the an385
> and an511 init functions, which I notice I also need
> to update to fix the equivalent bug there.)
...though I guess that's less true now we're using a
hex constant rather than decimal. So yeah, we could just
say 0x41045050.
thanks
-- PMM