[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 03/22] hw/timer/cmsdk-apb-dualtimer:
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 03/22] hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module |
|
Date: |
Thu, 23 Aug 2018 07:08:54 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/20/2018 07:10 AM, Peter Maydell wrote:
> + if (!(m->control & R_CONTROL_SIZE_MASK)) {
> + load = deposit32(load, 16, 16, extract32(m->load, 16, 16));
> + }
The same result, but clearer as
load = deposit32(m->load, 0, 16, load);
Several instances of this same pattern.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-arm] [PATCH 00/22] MPS devices: FPGAIO, timer, watchdogs, MSC, DMA, SPI, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 02/22] hw/misc/mps2-fpgaio: Implement PSCNTR and COUNTER, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 03/22] hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module, Peter Maydell, 2018/08/20
- Re: [Qemu-arm] [Qemu-devel] [PATCH 03/22] hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module,
Richard Henderson <=
- [Qemu-arm] [PATCH 05/22] hw/arm/mps2: Wire up dual-timer in mps2-an385 and mps2-an511, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 07/22] hw/arm/iotkit: Wire up the S32KTIMER, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 06/22] hw/arm/iotkit: Wire up the watchdogs, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 04/22] hw/arm/iotkit: Wire up the dualtimer, Peter Maydell, 2018/08/20