Re: [Qemu-arm] [PATCH 4/7] arm: Add additional datasheets and copyright lines

[Peter Maydell]

On 11 August 2018 at 10:08, Steffen Görtz <address@hidden> wrote:
> This patch adds a link to the product specification
> which contain additional information about the
> Nordic Semiconductor nRF51 SOC series.
>
> Furthermore it adds a copyright line to all
> files that get changed significantly.
>
> Signed-off-by: Steffen Görtz <address@hidden>
> ---
>  hw/arm/microbit.c          | 1 +
>  hw/arm/nrf51_soc.c         | 4 +++-
>  include/hw/arm/nrf51_soc.h | 1 +
>  3 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/microbit.c b/hw/arm/microbit.c
> index d6776dea0a..bb6ddb6a79 100644
> --- a/hw/arm/microbit.c
> +++ b/hw/arm/microbit.c
> @@ -3,6 +3,7 @@
>   * http://tech.microbit.org/hardware/
>   *
>   * Copyright 2018 Joel Stanley <address@hidden>
> + * Copyright 2018 Steffen Görtz <address@hidden>
>   *
>   * This code is licensed under the GPL version 2 or later.  See
>   * the COPYING file in the top-level directory.
> diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c
> index 85bce2c1e0..2265d30352 100644
> --- a/hw/arm/nrf51_soc.c
> +++ b/hw/arm/nrf51_soc.c
> @@ -1,8 +1,10 @@
>  /*
>   * Nordic Semiconductor nRF51 SoC
> - * http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.1.pdf
> + * Reference Manual: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf

This is downgrading from the 3.0.1 reference manual to the older
3.0. Is that intentional?

> + * Product Spec: http://infocenter.nordicsemi.com/pdf/nRF51822_PS_v3.1.pdf
>   *
>   * Copyright 2018 Joel Stanley <address@hidden>
> + * Copyright 2018 Steffen Görtz <address@hidden>
>   *
>   * This code is licensed under the GPL version 2 or later.  See
>   * the COPYING file in the top-level directory.
> diff --git a/include/hw/arm/nrf51_soc.h b/include/hw/arm/nrf51_soc.h
> index 24212f9174..45d9671dc3 100644
> --- a/include/hw/arm/nrf51_soc.h
> +++ b/include/hw/arm/nrf51_soc.h
> @@ -2,6 +2,7 @@
>   * Nordic Semiconductor nRF51  SoC
>   *
>   * Copyright 2018 Joel Stanley <address@hidden>
> + * Copyright 2018 Steffen Görtz <address@hidden>
>   *
>   * This code is licensed under the GPL version 2 or later.  See
>   * the COPYING file in the top-level directory.

It probably makes more sense to put the copyright line in the
same patch where you add enough code to the file for it to be
a substantive change.

thanks
-- PMM