[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH for-2.12] tcg: Introduce tcg_set_insn_start_param
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH for-2.12] tcg: Introduce tcg_set_insn_start_param |
Date: |
Tue, 10 Apr 2018 11:49:17 +0100 |
On 10 April 2018 at 01:35, Richard Henderson
<address@hidden> wrote:
> The parameters for tcg_gen_insn_start are target_ulong, which may be split
> into two TCGArg parameters for storage in the opcode on 32-bit hosts.
>
> Fixes the ARM target and its direct use of tcg_set_insn_param, which would
> set the wrong argument in the 64-on-32 case.
>
> Cc: address@hidden
> Reported-by: address@hidden
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>
> Peter, I'm not sure what the reproducer is for this reported problem.
It's a standalone binary, which was attached to this email:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05995.html
I've checked and this patch does indeed fix it.
Applied to target-arm.next, thanks.
-- PMM