Re: [Qemu-arm] [Qemu-devel] [PATCH] BCM2837 and machine raspi3

[bzt bzt]

On Tue, Nov 28, 2017 at 6:54 PM, Andrew Baumann <address@hidden> wrote:

> From: bzt bzt [mailto:address@hidden]
> Sent: Tuesday, 28 November 2017 03:27

> Yes, I agree. I've provided a parameterised version on Oct 24, which does not
> have a separate bcm2837 implementation. Is that patch ok?

That patch was moving in the right direction, but I think there were two problems with it. First, the right way to pass a parameter is via a property field (as Peter explained). Second, IMO the parameter should be the CPU model string to instantiate and not the Pi version number.

Thanks!
 

> Or should I wait
> for Alistair's patch (https://lists.gnu.org/archive/html/qemu-devel/2017-
> 10/msg04153.html)?

Alistair's patch doesn't actually help you as far as I can see, since it doesn't change what CPU bcm2836 instantiates. I think it just means that if the user specifies a different CPU type they get an error rather than being silently ignored.

It does add the CPU model string, which can and should be used in bcm2836 to decide which CPU to instatiate (regardless the method of passing that parameter). If I add yet another CPU model string, the two patch will be in conflict containing redundant information. Also I'm sure would raspi3 use different cpus, we should always instantiate the one the user specified. Although here is only one possible CPU model, still that seems to be the correct behavior. Don't get me wrong, I don't criticize, I just want to find the best solution. Setting the CPU model only once for each version seems right. I was thinking: if there's going to be a user specified CPU model string anyway, why not use that one?

bzt
 

Andrew