[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bm
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board |
Date: |
Tue, 10 Oct 2017 14:32:32 +0100 |
On 10 October 2017 at 14:30, Cédric Le Goater <address@hidden> wrote:
> On 10/09/2017 02:04 AM, Andrew Jeffery wrote:
>> On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote:
>>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)
>>> +{
>>> + AspeedSoCState *soc = &bmc->soc;
>>> +
>>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), "tmp423",
>>> 0x4c);
>>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), "tmp423",
>>> 0x4c);
>>> +
>>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), "tmp105",
>>> 0x4a);
>>
>> Looks like I need to track down newer versions of the schematics I have.
>
> the device on the board is a tmp275 but the tmp105 model is compatible.
This kind of deviation from the real hardware is worth having
a comment to document, I think.
thanks
-- PMM
- Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, (continued)
- Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, Cédric Le Goater, 2017/10/07
- Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, Cédric Le Goater, 2017/10/10
- Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, Peter Maydell, 2017/10/10
- Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, Cédric Le Goater, 2017/10/10
- Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, Peter Maydell, 2017/10/10
- Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, Cédric Le Goater, 2017/10/10
- Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, Peter Maydell, 2017/10/10
- Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, Cédric Le Goater, 2017/10/10
Re: [Qemu-arm] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board, Andrew Jeffery, 2017/10/08