Re: [Qemu-arm] [Qemu-devel PATCH 1/5] msf2: Add Smartfusion2 System timer

[sundeep subbaraya]

Hi Philippe,

On Mon, May 15, 2017 at 5:22 PM, Philippe Mathieu-Daudé <address@hidden> wrote:

Hi Subbaraya,

+        if (value & TIMER_MODE) {
+            qemu_log_mask(LOG_UNIMP, "64-bit mode not supported\n");

No need of trailing '\n', be more specific, something like:

    qemu_log_mask(LOG_UNIMP, TYPE_MSF2_TIMER ": 64-bit mode not
supported");

I mistaken with error_report(), qemu_log_mask() does use trailing newline, sorry!

thats ok :)

Thanks,

Sundeep 

Phil.