Re: [Qemu-arm] [PATCH 2/8] target/arm: optimize smul_dual() and neon

qemu-arm

Re: [Qemu-arm] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn

From:	Richard Henderson
Subject:	Re: [Qemu-arm] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op
Date:	Wed, 10 May 2017 13:20:38 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 05/10/2017 01:05 PM, Philippe Mathieu-Daudé wrote:

-    tcg_gen_shri_i32(t1, t1, 8);
-    tcg_gen_andi_i32(t1, t1, 0x00ff00ff);
+    tcg_gen_extract_i32(t1, t1, 8, 0x00ff00ff);


This is very wrong.  See my previous comment.


r~

Current Thread

[Next in Thread]

[Qemu-arm] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op, Philippe Mathieu-Daudé, 2017/05/10
- Re: [Qemu-arm] [Qemu-devel] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op, Eric Blake, 2017/05/10
  - Re: [Qemu-arm] [Qemu-devel] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op, Philippe Mathieu-Daudé, 2017/05/11
- Re: [Qemu-arm] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op, Richard Henderson <=
  - Re: [Qemu-arm] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op, Philippe Mathieu-Daudé, 2017/05/10
    - Re: [Qemu-arm] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op, Philippe Mathieu-Daudé, 2017/05/11