[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 5/5] slirp: add a fake NC-SI backe
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 5/5] slirp: add a fake NC-SI backend |
Date: |
Thu, 13 Apr 2017 19:27:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/13/2017 04:08 PM, Samuel Thibault wrote:
> Hello,
>
> Philippe Mathieu-Daudé, on jeu. 13 avril 2017 08:45:23 -0300, wrote:
>>> The NCSI header file <ncsi-pkt.h> comes from mainline Linux
>
> Please mention within the file which file it comes from exactly.
OK.
>>> + case NCSI_PKT_CMD_SMA:
>>> + rnh->common.length = htons(4);
>>> + break;
>>> + case NCSI_PKT_CMD_GVI:
>>> + rnh->common.length = htons(36);
>>> + break;
>>> + case NCSI_PKT_CMD_GC: {
>>> + rnh->common.length = htons(32);
> ...
>>> + break;
>>> + }
>>> +
>>> + case NCSI_PKT_CMD_GLS: {
>>> + rnh->common.length = htons(16);
>>> + break;
>>> + }
>>> +
>>> + slirp_output(slirp->opaque, ncsi_reply, sizeof(ncsi_reply));
>
> Are we really supposed to send sizeof(ncsi_reply), and not accordingly
> to the size announced withing the packet?
no. it should be: sizeof(header) + payload + 4. I will that in the next
version.
> Appart from that,
>
> Acked-by: Samuel Thibault <address@hidden>
Thanks,
C.
- [Qemu-arm] [PATCH v2 0/5] FTGMAC100 nic model for the Aspeed SoCs, Cédric Le Goater, 2017/04/13
- [Qemu-arm] [PATCH v2 1/5] hw/net: add MII definitions, Cédric Le Goater, 2017/04/13
- [Qemu-arm] [PATCH v2 2/5] net: add FTGMAC100 support, Cédric Le Goater, 2017/04/13
- [Qemu-arm] [PATCH v2 3/5] net/ftgmac100: add a 'aspeed' property, Cédric Le Goater, 2017/04/13
- [Qemu-arm] [PATCH v2 4/5] aspeed: add a FTGMAC100 nic, Cédric Le Goater, 2017/04/13
- [Qemu-arm] [PATCH v2 5/5] slirp: add a fake NC-SI backend, Cédric Le Goater, 2017/04/13
- Re: [Qemu-arm] [PATCH v2 0/5] FTGMAC100 nic model for the Aspeed SoCs, Jason Wang, 2017/04/14