[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v2 1/9] arm: Don't implement BXJ on M-profile CPUs
From: |
Peter Maydell |
Subject: |
[Qemu-arm] [PATCH v2 1/9] arm: Don't implement BXJ on M-profile CPUs |
Date: |
Mon, 10 Apr 2017 18:13:31 +0100 |
For M-profile CPUs, the BXJ instruction does not exist at all, and
the encoding should always UNDEF. We were accidentally implementing
it to behave like A-profile BXJ; correct the error.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
target/arm/translate.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index e32e38c..fe3f442 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -10485,7 +10485,12 @@ static int disas_thumb2_insn(CPUARMState *env,
DisasContext *s, uint16_t insn_hw
}
break;
case 4: /* bxj */
- /* Trivial implementation equivalent to bx. */
+ /* Trivial implementation equivalent to bx.
+ * This instruction doesn't exist at all for M-profile.
+ */
+ if (arm_dc_feature(s, ARM_FEATURE_M)) {
+ goto illegal_op;
+ }
tmp = load_reg(s, rn);
gen_bx(s, tmp);
break;
--
2.7.4
- [Qemu-arm] [PATCH v2 0/9] arm: Implement M profile exception return properly, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 7/9] arm: Track M profile handler mode state in TB flags, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 2/9] arm: Thumb shift operations should not permit interworking branches, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 5/9] arm: Move condition-failed codepath generation out of if(), Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 9/9] arm: Remove workarounds for old M-profile exception return implementation, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 3/9] arm: Factor out "generate right kind of step exception", Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 4/9] arm: Move gen_set_condexec() and gen_set_pc_im() up in the file, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 1/9] arm: Don't implement BXJ on M-profile CPUs,
Peter Maydell <=
- [Qemu-arm] [PATCH v2 8/9] arm: Implement M profile exception return properly, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 6/9] arm: Abstract out "are we singlestepping" test to utility function, Peter Maydell, 2017/04/10
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 0/9] arm: Implement M profile exception return properly, Richard Henderson, 2017/04/15