[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] stellaris: Don't hw_error() on bad register acces
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH] stellaris: Don't hw_error() on bad register accesses |
Date: |
Thu, 6 Apr 2017 17:37:28 +0100 |
On 6 April 2017 at 17:24, Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi Peter,
>
>
> On 04/06/2017 10:45 AM, Peter Maydell wrote:
>> default:
>> - hw_error("gptm_write: Bad offset 0x%x\n", (int)offset);
>> + qemu_log_mask(LOG_GUEST_ERROR,
>> + "GPTM: read at bad offset 0x%x\n", (int)offset);
>
>
> use HWADDR_PRIx to remove this unnecessary casts here in following changes?
>
> ie: "GPTM: read at bad offset 0x%" HWADDR_PRIx "\n", offset);
I don't think either of the two is clearly better for this
sort of case where the offset is known to be small, so I opted
to leave the code the way it was already written.
> either way:
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Thanks.
-- PMM