[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf t
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report() |
Date: |
Mon, 6 Mar 2017 21:41:25 +0000 |
On 6 March 2017 at 17:07, Krzysztof Kozlowski <address@hidden> wrote:
> On Mon, Mar 06, 2017 at 10:55:12AM -0600, Eric Blake wrote:
>> I don't see a 0/3 cover letter. When sending multiple patches, it's
>> always best to package them in-reply-to the cover letter ('git config
>> format.coverLetter auto' makes it easy to remember).
>
> The patches are trivial cleanups without any dependencies so the cover
> letter would be one sentence of "trivial cleanup". :)
>
> If that's the practice in qemu, I can send them, no problem.
Yeah, cover letter always for multipatch sets, please. We have
automated tooling that relies on this (and also manual humans).
thanks
-- PMM
Re: [Qemu-arm] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report(), Philippe Mathieu-Daudé, 2017/03/05
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report(), Eric Blake, 2017/03/06