|
From: | Sergey Sorokin |
Subject: | Re: [Qemu-arm] [PATCH v2] Improve the alignment check infrastructure |
Date: | Thu, 23 Jun 2016 17:13:41 +0300 |
On 06/23/2016 03:03 AM, Sergey Sorokin wrote:
So what's wrong in this part of the patch?
I think I just misread it.
On 06/22/2016 05:37 AM, Sergey Sorokin wrote:
+/* Use this mask to check interception with an alignment mask
+ * in a TCG backend.
+ */
+#define TLB_FLAGS_MASK (TLB_INVALID_MASK | TLB_NOTDIRTY | TLB_MMIO)
I think we ought to check this in tcg-op.c, rather than wait until generating
code in the backend.
I think it's better to check this in one place in get_alignment_bits() function
because there can be a direct call of helpers from softmmu_template.h.
[Prev in Thread] | Current Thread | [Next in Thread] |