[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [RFC 2/7] exec: keep CPUWatchpoint references internal
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-arm] [RFC 2/7] exec: keep CPUWatchpoint references internal |
|
Date: |
Fri, 17 Jun 2016 19:17:22 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17/06/2016 18:33, Alex Bennée wrote:
> + wp = g_array_index(cpu->watchpoints, CPUWatchpoint *, index);
Worth adding macros or inline functions cpu_breakpoint_at(cpu, index)
and cpu_watchpoint_at(cpu, index)? This will also be less churn in
patch 4, because the macros will always return CPU{Break,Watch}point *.
(I'm making the suggestion as I skim the patches, but they often apply
earlier in the series. Sorry).
Paolo