[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2] Fix confusing argument names in some common fu
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-arm] [PATCH v2] Fix confusing argument names in some common functions |
|
Date: |
Tue, 14 Jun 2016 16:05:50 -0300 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Jun 14, 2016 at 03:26:17PM +0300, Sergey Sorokin wrote:
> There are functions tlb_fill(), cpu_unaligned_access() and
> do_unaligned_access() that are called with access type and mmu index
> arguments. But these arguments are named 'is_write' and 'is_user' in their
> declarations. The patches fix the arguments to avoid a confusion.
>
> Signed-off-by: Sergey Sorokin <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Do you plan to change *_handle_mmu_fault(), arm_tlb_fill(), and
xtensa_get_physical_addr() later?
--
Eduardo