[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 02/10] target-i386: cpu: move feature
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 02/10] target-i386: cpu: move features logic that requires CPUState to realize time |
|
Date: |
Tue, 7 Jun 2016 15:07:33 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/07/2016 02:25 PM, Eduardo Habkost wrote:
> [...]
>> + /* TODO: convert plus_features & minus_features static vars
>> + * to global properties, once broken host_features is fixed
>> + */
>
> I will rewrite this to:
>
> /*TODO: cpu->host_features inclurrectly overwrites features
Was that supposed to be "incorrectly" or "currently"?
> * set using "feat=on|off". Once we fix this, we can convert
> * plus_features & minus_features to global properties
> * inside x86_cpu_parse_featurestr() too.
> */
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature