[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capab
From: |
Peter Xu |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface |
Date: |
Wed, 23 Mar 2016 20:04:49 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Mar 23, 2016 at 10:52:29AM +0100, Markus Armbruster wrote:
> The rule against returning non-dictionaries exists to avoid interfaces
> that cannot evolve. With a dictionary, you can evolve by adding
> members.
>
> The rule does *not* forbid returning lists of dictionaries. When a
> command fundamentally returns a list of things, being able to evolve the
> things suffices.
Ok.
>
> query-gic-capabilities looks like it fundamentally returns a list of
> capabilities. Returning ['GICCapability'] is just fine then.
I have posted v6 just as Eric has suggested. At least one advantage
is that it is easier to be extended (if needed) in the future, also
to follow the more-generic format to use dicts rather than
arrays. If you would not mind, I'll keep the dict interface there.
[...]
> In either case, drop the change to returns_whitelist.
Yep. Dropped in v6.
Thanks.
-- peterx
- Re: [Qemu-arm] [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct, (continued)
- [Qemu-arm] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface, Peter Xu, 2016/03/17
- [Qemu-arm] [PATCH v5 3/5] arm: enhance kvm_arm_create_scratch_host_vcpu, Peter Xu, 2016/03/17
- [Qemu-arm] [PATCH v5 4/5] kvm: add kvm_support_device() helper function, Peter Xu, 2016/03/17
- [Qemu-arm] [PATCH v5 5/5] arm: implement query-gic-capabilities, Peter Xu, 2016/03/17
- Re: [Qemu-arm] [PATCH v5 0/5] ARM: add query-gic-capabilities SMP command, Andrea Bolognani, 2016/03/21