[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2] Replaced get_tick_per_sec() by NANOSECONDS_PER
|
From: |
rutuja shah |
|
Subject: |
Re: [Qemu-arm] [PATCH v2] Replaced get_tick_per_sec() by NANOSECONDS_PER_SECOND |
|
Date: |
Mon, 21 Mar 2016 00:05:13 +0530 |
On Mon, Mar 21, 2016 at 12:01 AM, <address@hidden> wrote:
Hi,
Some lines seem to have been skipped some how. This patch replaces
get_ticks_per_sec() calls to NANOSECONDS_PER_SECOND. Also, as there
are no callers, get_ticks_per_sec() has been removed. Replacement
imporves readability and understandability of code.
> Example given by Paolo Bonzini,
>
> timer_mod(fdctrl->result_timer,
> qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + (get_ticks_per_sec() / 50));
>
> NANOSECONDS_PER_SECOND makes it obvious that the timer will expire in 1/50th
> of a second.
>
> ---
> audio/audio.c | 3 +--
> audio/noaudio.c | 8 ++++----
> audio/spiceaudio.c | 4 ++--
> audio/wavaudio.c | 2 +-
> backends/baum.c | 2 +-
> block/qed.c | 2 +-
> cpus.c | 6 +++---
> hw/acpi/core.c | 4 ++--
> hw/arm/omap1.c | 17 +++++++++--------
> hw/arm/spitz.c | 2 +-
> hw/arm/stellaris.c | 2 +-
> hw/arm/strongarm.c | 2 +-
> hw/audio/adlib.c | 2 +-
> hw/audio/sb16.c | 4 ++--
> hw/block/fdc.c | 4 ++--
> hw/block/pflash_cfi02.c | 8 ++++----
> hw/bt/hci-csr.c | 4 ++--
> hw/char/cadence_uart.c | 4 ++--
> hw/char/serial.c | 10 ++++++----
> hw/display/vga.c | 6 +++---
> hw/dma/rc4030.c | 2 +-
> hw/ide/core.c | 4 ++--
> hw/input/hid.c | 2 +-
> hw/input/tsc2005.c | 3 ++-
> hw/input/tsc210x.c | 3 ++-
> hw/intc/i8259.c | 2 +-
> hw/misc/arm_sysctl.c | 3 ++-
> hw/misc/macio/cuda.c | 16 ++++++++--------
> hw/misc/macio/macio.c | 2 +-
> hw/net/dp8393x.c | 2 +-
> hw/ppc/ppc.c | 21 ++++++++++++---------
> hw/ppc/ppc405_uc.c | 4 ++--
> hw/ppc/ppc_booke.c | 2 +-
> hw/sd/sdhci-internal.h | 2 +-
> hw/sparc64/sun4u.c | 4 ++--
> hw/timer/i8254.c | 4 ++--
> hw/timer/i8254_common.c | 6 +++---
> hw/timer/mc146818rtc.c | 14 ++++++++------
> hw/timer/omap_gptimer.c | 2 +-
> hw/timer/omap_synctimer.c | 3 ++-
> hw/timer/pl031.c | 10 +++++-----
> hw/timer/pxa2xx_timer.c | 18 ++++++++++--------
> hw/usb/hcd-ehci.c | 5 +++--
> hw/usb/hcd-musb.c | 2 +-
> hw/usb/hcd-ohci.c | 10 +++++-----
> hw/usb/hcd-uhci.c | 6 +++---
> hw/usb/tusb6010.c | 6 +++---
> hw/watchdog/wdt_diag288.c | 2 +-
> hw/watchdog/wdt_ib700.c | 2 +-
> include/hw/acpi/acpi.h | 2 +-
> include/qemu/timer.h | 9 ++-------
> monitor.c | 4 ++--
> target-ppc/kvm.c | 4 ++--
> 53 files changed, 143 insertions(+), 134 deletions(-)
> ---
> Thanks,
> Rutuja Shah